鲁树人 lsr
6 Followers · 0 Following
Repositories
2
 Projects Packages Public Activity Starred Repositories
lsr commented on pull request um/web#5 2022-11-20 15:46:27 +00:00
Add Tag Edit Function & Wasm for Qmc & Kgm

no error 应为 unknown error

lsr commented on pull request um/web#5 2022-11-20 15:46:27 +00:00
Add Tag Edit Function & Wasm for Qmc & Kgm

还是动态生成 mask 的方案… 直接删掉这部分也许会更好？

lsr commented on pull request um/web#5 2022-11-20 15:46:27 +00:00
Add Tag Edit Function & Wasm for Qmc & Kgm
  • musicMeta.common.artists == undefined ? musicMeta.common.artist : musicMeta.common.artists.toString() 可以替换为 `String(musicMeta.common.artists
lsr commented on pull request um/web#5 2022-11-20 15:46:27 +00:00
Add Tag Edit Function & Wasm for Qmc & Kgm

未使用的变量，后面直接内嵌了

lsr commented on pull request um/web#5 2022-11-20 15:46:27 +00:00
Add Tag Edit Function & Wasm for Qmc & Kgm
lsr suggested changes for um/web#5 2022-11-20 15:46:27 +00:00
Add Tag Edit Function & Wasm for Qmc & Kgm
lsr commented on pull request um/web#5 2022-11-20 15:46:26 +00:00
Add Tag Edit Function & Wasm for Qmc & Kgm

同上，

lsr commented on pull request um/web#5 2022-11-20 15:46:26 +00:00
Add Tag Edit Function & Wasm for Qmc & Kgm
lsr commented on pull request um/web#5 2022-11-20 15:46:26 +00:00
Add Tag Edit Function & Wasm for Qmc & Kgm

no error 应为 unknown error。

lsr commented on pull request um/web#5 2022-11-20 15:46:26 +00:00
Add Tag Edit Function & Wasm for Qmc & Kgm

reserve => preserve？

lsr commented on pull request um/web#5 2022-11-20 15:46:26 +00:00
Add Tag Edit Function & Wasm for Qmc & Kgm

可以将 frame.id 和 frame.value 都打印到 console，然后报错

lsr commented on pull request um/web#5 2022-11-20 15:46:26 +00:00
Add Tag Edit Function & Wasm for Qmc & Kgm

完全可以写一个包装函数，addOrReplaceTag。

lsr commented on pull request um/web#5 2022-11-20 15:46:26 +00:00
Add Tag Edit Function & Wasm for Qmc & Kgm

不清楚这个新增的判定的含义，加一些注释可能会比较好一点。

lsr commented on pull request um/web#5 2022-11-20 15:46:26 +00:00
Add Tag Edit Function & Wasm for Qmc & Kgm
lsr commented on pull request um/web#5 2022-11-20 15:46:26 +00:00
Add Tag Edit Function & Wasm for Qmc & Kgm

意义不明的更改。需要注释。

lsr commented on pull request um/web#5 2022-11-20 15:46:26 +00:00
Add Tag Edit Function & Wasm for Qmc & Kgm
lsr closed issue um/web#4 2022-11-20 00:51:47 +00:00
[酷我] 文件头改了
lsr commented on issue um/cli#36 2022-11-19 13:54:54 +00:00
【mflac0】no any decoder can resolve the file

手机版下载的文件已经不能解密了。

lsr opened issue um/web#4 2022-11-13 11:13:51 +00:00
[酷我] 文件头改了
lsr created pull request um/web#2 2022-04-27 23:37:51 +00:00
不依赖远端文件实现 KGM 解锁（内嵌 ~1K 的 mask 表数据）