From b8b20595583c549fbb77ea1f5b5e3658ff51ce95 Mon Sep 17 00:00:00 2001
From: Jixun Wu <jixun.moe@gmail.com>
Date: Fri, 16 Jun 2023 02:03:23 +0100
Subject: [PATCH] fix: performance issue when there's over 100s ekeys

---
 .../settings/panels/PanelQMCv2Key.tsx         | 58 +++---------------
 .../settings/panels/QMCv2/KeyInput.tsx        | 59 +++++++++++++++++++
 2 files changed, 66 insertions(+), 51 deletions(-)
 create mode 100644 src/features/settings/panels/QMCv2/KeyInput.tsx

diff --git a/src/features/settings/panels/PanelQMCv2Key.tsx b/src/features/settings/panels/PanelQMCv2Key.tsx
index e485d4b..8b7e7e7 100644
--- a/src/features/settings/panels/PanelQMCv2Key.tsx
+++ b/src/features/settings/panels/PanelQMCv2Key.tsx
@@ -7,26 +7,21 @@ import {
   Heading,
   Icon,
   IconButton,
-  Input,
-  InputGroup,
-  InputLeftElement,
-  InputRightElement,
   List,
-  ListItem,
   Menu,
   MenuButton,
   MenuDivider,
   MenuItem,
   MenuList,
   Text,
-  VStack,
 } from '@chakra-ui/react';
 import { useDispatch, useSelector } from 'react-redux';
-import { qmc2AddKey, qmc2ClearKeys, qmc2DeleteKey, qmc2UpdateKey } from '../settingsSlice';
+import { qmc2AddKey, qmc2ClearKeys } from '../settingsSlice';
 import { selectStagingQMCv2Settings } from '../settingsSelector';
-import React, { useState } from 'react';
-import { MdAdd, MdDelete, MdDeleteForever, MdExpandMore, MdFileUpload, MdVpnKey } from 'react-icons/md';
+import { useState } from 'react';
+import { MdAdd, MdDeleteForever, MdExpandMore, MdFileUpload } from 'react-icons/md';
 import { ImportFileModal } from './QMCv2/ImportFileModal';
+import { KeyInput } from './QMCv2/KeyInput';
 
 export function PanelQMCv2Key() {
   const dispatch = useDispatch();
@@ -34,9 +29,6 @@ export function PanelQMCv2Key() {
   const [showImportModal, setShowImportModal] = useState(false);
 
   const addKey = () => dispatch(qmc2AddKey());
-  const updateKey = (prop: 'name' | 'key', id: string, e: React.ChangeEvent<HTMLInputElement>) =>
-    dispatch(qmc2UpdateKey({ id, field: prop, value: e.target.value }));
-  const deleteKey = (id: string) => dispatch(qmc2DeleteKey({ id }));
   const clearAll = () => dispatch(qmc2ClearKeys());
 
   return (
@@ -50,7 +42,7 @@ export function PanelQMCv2Key() {
         客户端的情况下，其「离线加密文件」对应的「密钥」储存在独立的数据库文件内。
       </Text>
 
-      <Box pb={2} pt={2}>
+      <HStack pb={2} pt={2}>
         <ButtonGroup isAttached colorScheme="purple" variant="outline">
           <Button onClick={addKey} leftIcon={<Icon as={MdAdd} />}>
             添加一条密钥
@@ -68,48 +60,12 @@ export function PanelQMCv2Key() {
             </MenuList>
           </Menu>
         </ButtonGroup>
-      </Box>
+      </HStack>
 
       <Box flex={1} minH={0} overflow="auto" pr="4">
         <List spacing={3}>
           {qmc2Keys.map(({ id, key, name }, i) => (
-            <ListItem key={id} mt={0} pt={2} pb={2} _even={{ bg: 'gray.50' }}>
-              <HStack>
-                <Text w="2em" textAlign="center">
-                  {i + 1}
-                </Text>
-
-                <VStack flex={1}>
-                  <Input
-                    variant="flushed"
-                    placeholder="文件名"
-                    value={name}
-                    onChange={(e) => updateKey('name', id, e)}
-                  />
-
-                  <InputGroup size="xs">
-                    <InputLeftElement pr="2">
-                      <Icon as={MdVpnKey} />
-                    </InputLeftElement>
-                    <Input variant="flushed" placeholder="密钥" value={key} onChange={(e) => updateKey('key', id, e)} />
-                    <InputRightElement>
-                      <Text pl="2" color={key.length ? 'green.500' : 'red.500'}>
-                        <code>{key.length || '?'}</code>
-                      </Text>
-                    </InputRightElement>
-                  </InputGroup>
-                </VStack>
-
-                <IconButton
-                  aria-label="删除该密钥"
-                  icon={<Icon as={MdDelete} boxSize={6} />}
-                  variant="ghost"
-                  colorScheme="red"
-                  type="button"
-                  onClick={() => deleteKey(id)}
-                />
-              </HStack>
-            </ListItem>
+            <KeyInput key={id} id={id} ekey={key} name={name} i={i} />
           ))}
         </List>
         {qmc2Keys.length === 0 && <Text>还没有添加密钥。</Text>}
diff --git a/src/features/settings/panels/QMCv2/KeyInput.tsx b/src/features/settings/panels/QMCv2/KeyInput.tsx
new file mode 100644
index 0000000..77d193e
--- /dev/null
+++ b/src/features/settings/panels/QMCv2/KeyInput.tsx
@@ -0,0 +1,59 @@
+import {
+  HStack,
+  Icon,
+  IconButton,
+  Input,
+  InputGroup,
+  InputLeftElement,
+  InputRightElement,
+  ListItem,
+  Text,
+  VStack,
+} from '@chakra-ui/react';
+import { MdDelete, MdVpnKey } from 'react-icons/md';
+import { qmc2DeleteKey, qmc2UpdateKey } from '../../settingsSlice';
+import { useAppDispatch } from '~/hooks';
+import { memo } from 'react';
+
+export const KeyInput = memo(({ id, name, ekey, i }: { id: string; name: string; ekey: string; i: number }) => {
+  const dispatch = useAppDispatch();
+
+  const updateKey = (prop: 'name' | 'key', e: React.ChangeEvent<HTMLInputElement>) =>
+    dispatch(qmc2UpdateKey({ id, field: prop, value: e.target.value }));
+  const deleteKey = () => dispatch(qmc2DeleteKey({ id }));
+
+  return (
+    <ListItem mt={0} pt={2} pb={2} _even={{ bg: 'gray.50' }}>
+      <HStack>
+        <Text w="2em" textAlign="center">
+          {i + 1}
+        </Text>
+
+        <VStack flex={1}>
+          <Input variant="flushed" placeholder="文件名" value={name} onChange={(e) => updateKey('name', e)} />
+
+          <InputGroup size="xs">
+            <InputLeftElement pr="2">
+              <Icon as={MdVpnKey} />
+            </InputLeftElement>
+            <Input variant="flushed" placeholder="密钥" value={ekey} onChange={(e) => updateKey('key', e)} />
+            <InputRightElement>
+              <Text pl="2" color={ekey.length ? 'green.500' : 'red.500'}>
+                <code>{ekey.length || '?'}</code>
+              </Text>
+            </InputRightElement>
+          </InputGroup>
+        </VStack>
+
+        <IconButton
+          aria-label="删除该密钥"
+          icon={<Icon as={MdDelete} boxSize={6} />}
+          variant="ghost"
+          colorScheme="red"
+          type="button"
+          onClick={deleteKey}
+        />
+      </HStack>
+    </ListItem>
+  );
+});