bugfix for #36 #50 #59

nullptr-0 · 2023-08-28T15:46:32Z

nullptr-0 commented

2023-08-28 15:46:32 +00:00

bugfix for issues like #36 and #50

bugfix for issues like [#36] and [#50] [#36]: https://git.unlock-music.dev/um/web/issues/36 [#50]: https://git.unlock-music.dev/um/web/issues/50

nullptr-0 added 1 commit 2023-08-28 15:46:36 +00:00

e3188ef8eb bugfix for #36 #50

jixunmoe requested changes 2023-08-28 15:58:18 +00:00

src/decrypt/kgm_wasm.ts Outdated

						
				@ -35,2 +32,4 @@

				  }

				  // 每次处理 2M 的数据

				  const DECRYPTION_BUF_SIZE = Math.min(2 *1024 * 1024, kgmBlob.byteLength);

jixunmoe commented

2023-08-28 15:57:38 +00:00

DECRYPTION_BUF_SIZE 名称是常量。更改部分不应影响解密过程。

建议更改：

  const initBufSize = Math.min(2 *1024 * 1024, kgmBlob.byteLength); // 初始化缓冲区大小
  const pQmcBuf = KgmCryptoObj._malloc(initBufSize);
  KgmCryptoObj.writeArrayToMemory(kgmBuf.slice(0, initBufSize), pQmcBuf);

另外 pQmcBuf 可以顺便改成 pInitBuf 或其他不含 qmc 字样的变量名。

`DECRYPTION_BUF_SIZE` 名称是常量。更改部分不应影响解密过程。建议更改： ```js const initBufSize = Math.min(2 *1024 * 1024, kgmBlob.byteLength); // 初始化缓冲区大小 const pQmcBuf = KgmCryptoObj._malloc(initBufSize); KgmCryptoObj.writeArrayToMemory(kgmBuf.slice(0, initBufSize), pQmcBuf); ``` 另外 `pQmcBuf` 可以顺便改成 `pInitBuf` 或其他不含 `qmc` 字样的变量名。

nullptr-0 marked this conversation as resolved

src/decrypt/qmc_wasm.ts Outdated

						
				@ -36,2 +33,4 @@

				  }

				  // 每次处理 2M 的数据

				  const DECRYPTION_BUF_SIZE = Math.min(2 *1024 * 1024, qmcBlob.byteLength);

jixunmoe commented

2023-08-28 15:58:06 +00:00

参见 KGM 部分的修改建议。

nullptr-0 marked this conversation as resolved

nullptr-0 force-pushed pr from e3188ef8eb to 7ade485d2e

2023-08-28 16:30:08 +00:00

Compare

jixunmoe requested review from jixunmoe 2023-08-28 17:09:00 +00:00

jixunmoe approved these changes 2023-08-28 17:09:23 +00:00

jixunmoe merged commit 6603210ad9 into master

2023-08-28 17:10:06 +00:00

jixunmoe referenced this issue from a commit

2023-08-28 17:10:06 +00:00

Merge pull request 'bugfix for #36 #50' (#59) from nullptr-0/web:pr into master

nullptr-0 deleted branch pr

2023-08-28 17:14:48 +00:00

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: um/web#59